fix(modal): remove warning during state update. (#1448)

akveo · Jul 7, 2021 · 273746a · 273746a
1 parent a985f07
commit 273746a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/components/ui/modal/modal.component.tsx b/src/components/ui/modal/modal.component.tsx
@@ -116,6 +116,10 @@ export class Modal extends React.PureComponent<ModalProps, State> {
     if (this.modalId && !this.props.visible) {
       this.hide();
     }
+
+    if (this.modalId && this.props.visible) {
+      ModalService.update(this.modalId, this.renderContentElement());
+    }
   }
 
   public componentWillUnmount(): void {
@@ -158,10 +162,6 @@ export class Modal extends React.PureComponent<ModalProps, State> {
   };
 
   public render(): React.ReactNode {
-    if (this.modalId && this.props.visible) {
-      ModalService.update(this.modalId, this.renderContentElement());
-    }
-
     return null;
   }
 }