-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: change components captions structure #1349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the final look of the component configured with caption
or captionIcon
props. Since we don't use this default spacing between caption text and Input field, a user will more likely have to apply it on his own. Which makes Eva not Eva.
Instead, I would suggest removing the captionIcon
property and wrap the entire caption
element in FalsyFC
or better FalsyText
so we can remove the caption container view. This way of composing elements will allow us reducing useless spacings between components.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1253
Related eva fix.
Related kittenTricks update.