Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: change components captions structure #1349

Merged
merged 13 commits into from
Mar 23, 2021

Conversation

whitestranger7
Copy link
Contributor

@whitestranger7 whitestranger7 commented Feb 11, 2021

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #1253
Related eva fix.
Related kittenTricks update.

@whitestranger7 whitestranger7 changed the title fix: remove useless margin for input element fix: remove useless margin for input, datepicker & select elements Feb 11, 2021
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the final look of the component configured with caption or captionIcon props. Since we don't use this default spacing between caption text and Input field, a user will more likely have to apply it on his own. Which makes Eva not Eva.

Instead, I would suggest removing the captionIcon property and wrap the entire caption element in FalsyFC or better FalsyText so we can remove the caption container view. This way of composing elements will allow us reducing useless spacings between components.

@whitestranger7 whitestranger7 changed the title fix: remove useless margin for input, datepicker & select elements update: change components captions structure Mar 7, 2021
@whitestranger7 whitestranger7 marked this pull request as draft March 7, 2021 17:19
@malashkevich malashkevich marked this pull request as ready for review March 12, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altering margin/border on Input element using style props not working as expected
3 participants