Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): token-tool integration #191

Merged
merged 18 commits into from
Dec 10, 2018

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Dec 3, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • add design configuration mock
  • implements withDesign method which provides component with 'design' prop
  • implements service methods to create component styles described in design configuration
  • covered by tests

* refactor(theme): adopt to new tokens type
}
}

const Result = Shadow;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapper

@@ -0,0 +1,8 @@
import React from 'react';
import { ThemeType } from '..';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

*
* @return any.
*/
export function createFlatStyle(theme: ThemeType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createStyle

TokenType,
} from '@rk-kit/design';

export const defaultVariant = 'default';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase


const mapVariant = (v: string) => createStyleFromVariant(theme, design, v);
const mergeStyles = (origin: StyleType, next: StyleType) => ({ ...origin, ...next });

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-process arrays and check for default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tests for array!

@artyorsh artyorsh force-pushed the feat/token-tool-integration-mocked branch 2 times, most recently from 3ebed2c to ea2dbc5 Compare December 4, 2018 16:14
@artyorsh artyorsh force-pushed the feat/token-tool-integration-mocked branch from ea2dbc5 to c47e5c3 Compare December 5, 2018 07:36
@malashkevich malashkevich merged commit c97fa06 into next Dec 10, 2018
@malashkevich malashkevich deleted the feat/token-tool-integration-mocked branch December 10, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➡️ Next Upcoming changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants