Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): button component. Closes #260 #268

Merged
merged 4 commits into from
Feb 26, 2019
Merged

feat(ui): button component. Closes #260 #268

merged 4 commits into from
Feb 26, 2019

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Feb 22, 2019 •
edited
Loading

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • Integrates button component
  • Fixes bundler and compiler issues which where revealed during merge 😞

@artyorsh artyorsh added needs review 📱 Components components module-specific ➡️ Next Upcoming changes labels Feb 22, 2019
@artyorsh artyorsh changed the title feat(ui): button component feat(ui): button component. Closes #260 Feb 22, 2019
malashkevich
malashkevich reviewed Feb 26, 2019
View reviewed changes
src/framework/ui/button/button.component.tsx
);
};

private createComponentChildren = (style: StyleType): React.ReactNode => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not render*?

@32penkin 32penkin merged commit 1ea28bd into next Feb 26, 2019
@artyorsh artyorsh deleted the feat/button branch February 26, 2019 15:23
@artyorsh artyorsh self-assigned this Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@32penkin 32penkin 32penkin approved these changes

@malashkevich malashkevich malashkevich approved these changes

Assignees

@artyorsh artyorsh

Labels
➡️ Next Upcoming changes 📱 Components components module-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artyorsh @malashkevich @32penkin