Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): input labels #361

Merged
merged 2 commits into from
Apr 19, 2019
Merged

feat(ui): input labels #361

merged 2 commits into from
Apr 19, 2019

Conversation

32penkin
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • ability to add label implemented
  • ability to add caption/caption-image implemented
  • "size" issues fixed

@32penkin 32penkin added needs review 📱 Components components module-specific ➡️ Next Upcoming changes labels Apr 18, 2019
@32penkin 32penkin requested a review from artyorsh April 18, 2019 12:56
@32penkin 32penkin self-assigned this Apr 18, 2019
artyorsh
artyorsh suggested changes Apr 18, 2019
View reviewed changes
src/framework/ui/common/mapping.json Show resolved Hide resolved
src/framework/ui/input/input.component.tsx Outdated Show resolved Hide resolved
src/framework/ui/input/input.component.tsx Show resolved Hide resolved
src/framework/ui/input/input.component.tsx Outdated Show resolved Hide resolved
@32penkin 32penkin requested a review from artyorsh April 19, 2019 08:21
@32penkin 32penkin merged commit dc89874 into next Apr 19, 2019
@32penkin 32penkin deleted the feat/input-labels branch April 19, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artyorsh artyorsh artyorsh approved these changes

Assignees

@32penkin 32penkin

Labels
➡️ Next Upcoming changes 📱 Components components module-specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@32penkin @artyorsh