Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): components docs and application add #386

Merged
merged 18 commits into from
May 13, 2019
Merged

feat(docs): components docs and application add #386

merged 18 commits into from
May 13, 2019

Conversation

32penkin
Copy link
Member

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@32penkin 32penkin requested a review from artyorsh May 10, 2019 13:52
@32penkin 32penkin self-assigned this May 10, 2019
artyorsh
artyorsh suggested changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@artyorsh artyorsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Build fails because of package-lockconflicts
  • Tests fail because it tries running docs module tests. Should be ignored

@32penkin 32penkin requested a review from artyorsh May 10, 2019 16:21
@32penkin 32penkin merged commit 885fb81 into next May 13, 2019
@artyorsh artyorsh deleted the feat/docs branch May 13, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artyorsh artyorsh artyorsh approved these changes

Assignees

@32penkin 32penkin

Labels
➡️ Next Upcoming changes 📚 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@32penkin @artyorsh @yggg