Select component mutating props

[saby1101]

🐛 Bug Report

Passing read-only array to Select component (Multi-select mode) causes crash.
"selectedOption is readonly"

To Reproduce

Steps to reproduce the behavior:

• pass Object.freeze([array]) to selectedOption prop
• select another option from the UI

Issue is at

react-native-ui-kitten/src/components/ui/select/selection.strategy.ts

Line 83 in f5f13d7

this.selectedOption.push(option);

Expected behavior

No crash

Link to runnable example or repository (highly encouraged)

UI Kitten and Eva version

Package	Version
@ui-kitten/components	4.3.2

Environment information

[artyorsh]

Hi @saby1101
Can you please describe the use-case when Object.freeze needs to be passed?

[saby1101]

If you use immerjs, it will use Object.freeze internally on the objects to ensure immutability.

Also, as far as I understand props of a component should not be modified. Quoting from a StackOverflow answer: "A component should manage its own state, but it should not manage its own props. props is essentially "state that is managed by the component owner." That's why props are immutable."

https://stackoverflow.com/questions/47471131/why-are-react-props-immutable

[artyorsh]

Got it. Let's keep it open so we can back to this in the nearest future. Thanks for reporting 👍
Btw, do you have some workaround on it?

[saby1101]

Currently, I am making a copy of the object and then assigning it to props.