Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected binaries in the published crate #27

Closed
FauxFaux opened this issue Sep 27, 2019 · 3 comments
Closed

Unexpected binaries in the published crate #27

FauxFaux opened this issue Sep 27, 2019 · 3 comments

Comments

@FauxFaux
Copy link

A concerned citizen, although apparently not concerned enough to use github, has noticed something that concerns them.
Some binaries, named vim10m_match and vim10m_table, have made it into the vte 0.3.3 release on crates.io, visible https://docs.rs/crate/vte/0.3.3/source/

These binaries then get vendor'd into the actual rustc source downloads.

Could you please do a release which.. doesn't have random binaries, and other unpublished code, in?

@jwilm
Copy link
Collaborator

jwilm commented Sep 27, 2019

Browsing the link you provided, there's a vim10m.rs file that looks familiar. I need to check my other machine, but I believe that's code related to some experimenting I did a long time ago. I guess cargo must bundle whatever is in the working directory? Or at least did at the time..

I'll report back on that. We can certainly publish a clean version in any case.

@FauxFaux
Copy link
Author

I believe cargo publish (nowadays) tries hard to not publish uncommitted stuff, but maybe you were on a branch, or something. All good!

@kchibisov
Copy link
Member

@chrisduerr I feel like this should be closed now, since we've released v0.4.0 and v0.5.0 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants