Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional package loading like #8

Closed
vollmersj opened this issue Sep 4, 2018 · 3 comments
Closed

Conditional package loading like #8

vollmersj opened this issue Sep 4, 2018 · 3 comments

Comments

@vollmersj
Copy link
Collaborator

https://github.com/JuliaIO/FileIO.jl/blob/8656519a4eb45915c1eff21cac17d14054244c5f/src/loadsave.jl#L1-L50

@ablaom
Copy link
Member

ablaom commented Oct 15, 2018

This solution uses Base.__toplevel__, which is apparently not recommended:

StefanKarpinski
Steward
Jun 14
Messing around with Base.toplevel or Base.loaded_modules is not recommended and may break at any time in a 1.x release. I don’t really understand the use case for CxxWrap well enough to give advice on a better way to do this. @barche, can you elaborate?

From this Discourse thread.

@ablaom
Copy link
Member

ablaom commented Oct 16, 2018

Another Discourse thread discusses conditional loading.

@ysimillides
Copy link
Collaborator

We have conditional package loading using Requires, will be moving away from this in the near future to Separate Packages for dependencies.

@ablaom ablaom mentioned this issue Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vollmersj @ysimillides @ablaom