Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or remove legacy workflows #1780

Closed
JimMadge opened this issue Apr 11, 2024 · 4 comments · Fixed by #2085
Closed

Fix or remove legacy workflows #1780

JimMadge opened this issue Apr 11, 2024 · 4 comments · Fixed by #2085
Assignees
Labels
bug Problem when deploying a Data Safe Haven. release: non-essential Issues that at not essential to close for a release
Milestone

Comments

@JimMadge
Copy link
Member

Workflows to,

  • Update SRD packages (debs not on the ubuntu repos)
  • Update package allowlists for PyPI and CRAN

are currently failing.

We need to either fix these to work with the next release or remove them if they are no longer needed.

@JimMadge JimMadge added this to the Release 5.0.0rc2 milestone Apr 11, 2024
@jemrobinson
Copy link
Member

I think you just deleted the files that these workflows change!

@JimMadge
Copy link
Member Author

JimMadge commented Apr 11, 2024

Would they be used if there were still there?

(Assuming they were at /deployment/secure_research_desktop/...)

@jemrobinson
Copy link
Member

For the moment yes (because the Pulumi code currently builds images on-the-fly without using a gallery). We could either:

  • restore /deployment/secure_research_desktop for the moment
  • prioritise integrating bureau into this workflow
  • decide that on-the-fly builds that only pre-install a small number of tools are good enough for our next release

@JimMadge
Copy link
Member Author

Agreed, we should decide that. I would lean towards stock Ubuntu with minimal changes for simplicity and looking forward to Bureau in the following release.

I think we should be careful not to put too much into the 5.0.0rc2 and (for the moment) keep it to the essentials.

@JimMadge JimMadge self-assigned this May 17, 2024
@jemrobinson jemrobinson added bug Problem when deploying a Data Safe Haven. release: non-essential Issues that at not essential to close for a release labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Problem when deploying a Data Safe Haven. release: non-essential Issues that at not essential to close for a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants