People without any Forecast assignments are silently dropped

[yongrenjie]

(via @LevanBokeria, thanks for reporting! 😊)

whatwhat/lib/schedule.ml

Lines 199 to 215 in a2eaa53

	(* In a first pass, we remove anyone who is not in REG (as determined by
	roles) or who is only assigned to UNAVAILABLE, as we probably don't need to
	care about these. *)
	let is_available (fc_p : Forecast.person) =
	(* Has REG role *)
	List.mem "REG" fc_p.roles
	&& (* Is currently assigned to something that isn't just UNAVAILABLE *)
	List.exists
	(fun (a : Forecast.assignment) ->
	get_first_day a.allocation < CalendarLib.Date.today ()
	&& get_last_day a.allocation > CalendarLib.Date.today ()
	&& a.entity = Person fc_p
	&& a.project.programme <> "UNAVAILABLE")
	fc_assignments
	in
	let fc_all = List.filter is_available fc_people |> FcSet.of_list in
	let gh_all = GhSet.of_list gh_people in

These lines drop anybody who simply doesn't have any assignments at all.

They should really be reported as 100% unassigned