Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: readd support for Amazon devices #2746

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

alams154
Copy link
Contributor

Reintroduces Amazon manufactured devices to be exposed by the integration. This is especially useful for Amazon Smart Plugs which cannot be added to Home Assistant via any other means.

@coveralls
Copy link

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12359798384

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 9.357%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/alexa_entity.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
custom_components/alexa_media/alexa_entity.py 1 29.9%
Totals Coverage Status
Change from base Build 12274121981: -0.002%
Covered Lines: 320
Relevant Lines: 3420

💛 - Coveralls

@alandtse
Copy link
Owner

Thanks. Can we simplify the test so it's

appliance.get("manufacturerName") in ["x","y","z"]

@alandtse alandtse merged commit bd0d2ca into alandtse:dev Dec 17, 2024
4 checks passed
alandtse added a commit that referenced this pull request Dec 17, 2024
feat: readd support for Amazon devices (#2746)
@danielbrunt57
Copy link
Collaborator

danielbrunt57 commented Dec 27, 2024

Reintroduces Amazon manufactured devices to be exposed by the integration.

When was it removed??

@danielbrunt57
Copy link
Collaborator

Aren't Amazon Smart Plugs similar to Air Quality Monitors in that they exist in Amazon Alexa but are not connected via an Echo device? I would think it would make more sense to modify the parse_alexa_entities to process them like it does the AIAQM sensors rather than fudging the is_local test since they aren't 'local' in the original design concept of alexa_entity.py...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants