Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump deps, support typescript 4.0+ #51

Merged
merged 3 commits into from
Sep 25, 2020
Merged

feat: bump deps, support typescript 4.0+ #51

merged 3 commits into from
Sep 25, 2020

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Sep 23, 2020

@@ -2,8 +2,8 @@ const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin');

module.exports = {
stories: [
'../stories/**/index.(js|ts)',
'../stories/**/*.stories.(js|ts|mdx)',
'../stories/**/index.@(js|ts)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ 啥意思?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fengtianze
Copy link
Collaborator

  1. 对项目升级有多大影响?
  2. 有没有简单的最佳实践可以在新开发组件时无脑避开这种细节问题?

@JounQin
Copy link
Member Author

JounQin commented Sep 25, 2020

@fengtianze

  1. 对项目没有影响
  2. 4.0 后 TS 对覆盖访问器的 pattern 直接报错了,所以也不存在问题(昨天的文章里有提到)

@JounQin JounQin merged commit 7291f95 into master Sep 25, 2020
@JounQin JounQin deleted the chore/deps branch September 25, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants