Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ModelID and SetModelID to appease golint #27

Closed
penguinpowernz opened this issue Sep 22, 2017 · 2 comments
Closed

Use ModelID and SetModelID to appease golint #27

penguinpowernz opened this issue Sep 22, 2017 · 2 comments

Comments

@penguinpowernz
Copy link

Currently the interface is:

type Model interface {
  ModelId() string
  SetModelId(string)
}

But that causes golint to whinge. The correct way according to go is:

type Model interface {
  ModelID() string
  SetModelID(string)
}

Will obviously have to manage people already using this, maybe will need to bump to v2?

@albrow albrow closed this as completed in 69279b7 Jan 12, 2018
@albrow
Copy link
Owner

albrow commented Jan 12, 2018

@penguinpowernz I fixed the issue and released Version 0.19.0. Because semantic versioning allows for breaking changes before version 1.0, I elected not to bump the major version at this time. Zoom is still on version 0.x and the README is pretty clear about this and what it means.

@penguinpowernz
Copy link
Author

Awesome dude! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants