Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Single Page Application #38

Open
alonfnt opened this issue Feb 10, 2020 · 1 comment
Open

Single Page Application #38

alonfnt opened this issue Feb 10, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alonfnt
Copy link

alonfnt commented Feb 10, 2020

I believe that the guidelines say that a single page application shouldn't have a visible header. However this is not always applied.

I think if a single page switch is added to the new app configuration
single_page_application

it would help create more consistent apps. The final look would be
single_page_exemple

and in order to achieve this, we only need to replace this block of code in the activate method in Application.vala

window.title = "Single Page Application";
window.set_default_size (900, 640);
window.add (main);
window.show_all ();

for

window.set_default_size (900, 640);
          
var titlebar = new Gtk.HeaderBar ();
titlebar.title = "Single Page Application";
titlebar.show_close_button = true;
titlebar.has_subtitle = false;
var titlebar_style_context = titlebar.get_style_context ();
titlebar_style_context.add_class (Gtk.STYLE_CLASS_FLAT);
            
window.add (main);
window.set_titlebar (titlebar);

so developers don't have to look for the Gtk Style class and so.

Thoughts?

@OctoD
Copy link
Member

OctoD commented Feb 17, 2020

It would be a good idea, could you please open a PR for it? Thanks!

@OctoD OctoD added the enhancement New feature or request label Feb 17, 2020
@OctoD OctoD added help wanted Extra attention is needed good first issue Good for newcomers labels May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants