fix: persist login state across refreshes #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moldy530
force-pushed
the
moldy/fix-flicker
branch
from
510b771 to
c18a962
Compare
7 tasks
moldy530
force-pushed
the
moldy/fix-flicker
branch
from
c18a962 to
9ce0510
Compare
moldy530
force-pushed
the
moldy/fix-flicker
branch
from
9ce0510 to
9961162
Compare
moldy530
force-pushed
the
moldy/fix-flicker
branch
from
9961162 to
48311b3
Compare
rthomare
approved these changes
Oct 8, 2024
| showEmail: true, | ||
| showExternalWallets: false, | ||
| showPasskey: true, | ||
| addPasskey: true, |
There was a problem hiding this comment.
I guess fine to do it in another PR!
There was a problem hiding this comment.
ah yea I think that's what Iyk and Rob are gonna tackle changing
moldy530
force-pushed
the
moldy/fix-flicker
branch
from
48311b3 to
cca2633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
I had to move a number of things around to enable the cookie storage on the app so that's most of this PR. That was actually the only thing missing to remove the loading flicker. I also refactored the Mint Card slightly because that was also causing a flicker. Now it always renders the mint card if you're logged in, just disables the button until minting is ready.
PR-Codex overview
This PR focuses on updating the configuration and functionality of the
AuthCardHeader,Providers, and various components to enhance the authentication process and state management. It also upgrades the versioning of the configuration and related components.Detailed summary
versionfrom8to9in multiple files.AuthCardHeaderto accept new props.Providersto includeinitialStateprop.alchemyConfigandinitialStateintoRootLayout.MintCardto handle loading states better.AuthCardWrapperby removing unnecessary client checks.RootLayoutfor state initialization.config.tsx.