Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable specifying the domain that a session is available on (if storage supports it) #1022

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Oct 7, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the configuration options for session management by adding an optional domain property to the sessionConfig and related functions, allowing for more flexible cookie storage.

Detailed summary

  • Added domain property to sessionConfig in createConfig.ts.
  • Updated type definitions in types.ts to include domain? in CreateConfigProps.
  • Modified storage function signature to accept domain?.
  • Updated JSDoc comments in cookies.ts to reflect changes in parameter types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 4:29pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 4:29pm

@moldy530 moldy530 merged commit 90d859c into main Oct 8, 2024
6 checks passed
@moldy530 moldy530 deleted the moldy/domain-cookies branch October 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants