-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update demo video, scroll and dimensions on mobile #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iykazrji
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
October 10, 2024 19:14
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iykazrji
changed the title
feat: update scroll behaviour and splash page dimensions to fit actions above the fold
feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions to fit actions above the fold
Oct 10, 2024
iykazrji
changed the title
feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions to fit actions above the fold
feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions
Oct 10, 2024
… iyk/fix-mobile-demo-video
iykazrji
changed the title
feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions
feat: update demo video, scroll and dimensions on mobile
Oct 10, 2024
rthomare
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)Screenshots
RPReplay_Final1728586503.MP4
PR-Codex overview
This PR focuses on enhancing the layout and styling of the
TopNav
,MobileSplashPage
, and the mainHome
component in the application, improving responsiveness and visual consistency.Detailed summary
TopNav
to usefixed
positioning and adjusted background classes.Home
component to useh-auto
for dynamic height and added margin adjustments for child elements.MobileSplashPage
to improve text sizes and layout, including a video element's dimensions.