Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure mobile landing page doesn't scroll #1045

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Oct 10, 2024

Pull Request Checklist

Screenshots:

iPhone SE
image

iPhone XR
image


PR-Codex overview

This PR focuses on improving the layout and styling of components in the page.tsx and MobileSplashPage.tsx files, enhancing responsiveness and visual consistency.

Detailed summary

  • Updated class names in page.tsx for improved layout and padding.
  • Added padding to the div elements for better spacing in page.tsx.
  • Modified the structure of MobileSplashPage.tsx to improve layout and responsiveness.
  • Adjusted maximum height and padding in the main container of MobileSplashPage.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 1:35am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 1:35am

rthomare
rthomare previously approved these changes Oct 10, 2024
@rthomare rthomare merged commit f319280 into main Oct 11, 2024
6 checks passed
@rthomare rthomare deleted the iyk/remove-mobile-splash-scroll branch October 11, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants