Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default auth #1049

Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix: update default auth #1049

merged 4 commits into from
Oct 11, 2024

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Oct 11, 2024

Pull Request Checklist

Default auth state should now have eoa wallets enabled and disable add passkey after signup.
It also resets the auth step to initial if you close the modal. If you have passkey enabled and passkey after signup you should be prompted after the email flow. If you have passkey after signup disabled you should not be prompted after the flow.

Screenshot 2024-10-11 at 10 18 04 AM

Testing steps:

On mobile when you begin login click a non-email method. Close the modal before submitting. When you re-open the modal you should be at the initial state.


PR-Codex overview

This PR focuses on updating authentication configuration and logic in the UI, specifically regarding external wallets and passkey settings, as well as refining the authentication flow in the AuthCardContent component.

Detailed summary

  • Changed showExternalWallets from false to true.
  • Changed addPasskey from true to false.
  • Added addPasskeyOnSignup to the auth context.
  • Modified the onClose callback to set the auth step to initial.
  • Updated createPasskeyAfter to use addPasskeyOnSignup.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 6:00pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 6:00pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants