Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select does not use theme token for bg #1085

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Oct 16, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the styling of a div and a select-menu component to improve their appearance and responsiveness.

Detailed summary

  • In page.tsx, changed className from hidden lg:flex to hidden lg:block.
  • Updated background and text colors based on the showCode condition.
  • In select-menu.tsx, changed background color from bg-bg-surface-default to bg-[white] for better visibility.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:34pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 7:34pm

@RobChangCA RobChangCA merged commit aaeb288 into main Oct 17, 2024
6 checks passed
@RobChangCA RobChangCA deleted the rob/dark-theme-select branch October 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants