-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate sdk + nft contract for onboarding #11
Conversation
metaForStepIdentifier, | ||
} from "./OnboardingDataModels"; | ||
|
||
async function pollForLambdaForComplete( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh so you shouldn't need this if you're waiting for UOs to complete anymore. The SDK has a sendTransaction
method available that will handle this for you and return a tx_hash
instead of a UO hash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need this function for a Faucet check but sounds good for the user op!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix this up stack because I do a major onboarding refactor later on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we omit all of the out
from building the contracts? might be nice to use something like the wagmi cli for generating the ABI defs eg: https://github.com/OMGWINNING/ens-offchain-resolver/pull/2#discussion_r1203166796
we can also gitignore the generated files too and have a predev
script defined that makes sure the wagmi cli generates the files
8a3d496
to
eb3b14f
Compare
e51a416
to
7d238e1
Compare
Will do the wagmi based cli for abi generation in a follow up PR. |
7d238e1
to
245641f
Compare
import { RequestFunds } from "./RequestFunds"; | ||
|
||
// .01 in wei | ||
export const MIN_ONBOARDING_WALLET_BALANCE = BigInt("10000000000000000"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to do 10_000_000_000_000_000n
Description - replace simpleAccount with lightAccount in example dapp Tests SCA: https://sepolia.etherscan.io/address/0xfbb20F094F3c998B8b6B878e94D241048418aa85#events https://github.com/OMGWINNING/aa-sdk-private/assets/43521356/1287a2f8-06fb-49b4-999b-7330fadae504
This Stack
This pull request introduces a comprehensive end-to-end decentralized application that serves as a prime example for users of our SDK, providing a practical demonstration of various interactions and functionalities, fostering a solid foundation for their own development endeavors.
This PR
Compiles and update NFT Contract and ABI, and adds first version of onboarding
Test Plan
test.example.mov