Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor a11y enhancements #1110

Merged
merged 3 commits into from
Oct 30, 2024
Merged

fix: minor a11y enhancements #1110

merged 3 commits into from
Oct 30, 2024

Conversation

RobChangCA
Copy link
Collaborator

@RobChangCA RobChangCA commented Oct 28, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing accessibility by adding id attributes to various elements and replacing <p> tags with <label> tags to improve semantic structure.

Detailed summary

  • Added id="color-picker" to the ColorPicker component.
  • Added id="logo-remove" to the remove button.
  • Changed <p> to <label> for authentication method, with htmlFor.
  • Added id="logo-upload" to FileUploadInput.
  • Added id="code-preview-switch" to the CodePreviewSwitch.
  • Changed <p> to <label> for Theme and Color sections with htmlFor.
  • Changed <p> to <label> for Logo with htmlFor.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:43am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:43am

moldy530
moldy530 previously approved these changes Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants