Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show Oauth errors in from UI components #1118

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

alex-miao
Copy link
Collaborator

@alex-miao alex-miao commented Oct 31, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing error handling in the useOAuthVerify hook by logging errors to the console when an error occurs during the OAuth verification process.

Detailed summary

  • Added console.error(err); to log errors in the onError callback of the OAuth verification process.
  • Updated the setAuthStep function to indicate the completion of the OAuth process with the type "oauth_completing" and the associated config.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:03am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 1:03am

@alex-miao alex-miao merged commit 8331372 into main Oct 31, 2024
6 checks passed
@alex-miao alex-miao deleted the alex/show-errors branch October 31, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants