fix: bigint multiply was sometimes generating floats #1135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR primarily focuses on updating the
uuid
dependency fromuuidv4
touuid
version11.0.2
and enhancing thebigIntMultiply
function with additional test cases and improved rounding logic.Detailed summary
uuid
dependency inaccount-kit/logging/package.json
fromuuidv4
touuid
version11.0.2
.bigint.test.ts
to verify multiplication with default settings.bigint.ts
to useMath.round
for better accuracy.