Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bigint multiply was sometimes generating floats #1135

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Nov 7, 2024

Pull Request Checklist


PR-Codex overview

This PR primarily focuses on updating the uuid dependency from uuidv4 to uuid version 11.0.2 and enhancing the bigIntMultiply function with additional test cases and improved rounding logic.

Detailed summary

  • Updated uuid dependency in account-kit/logging/package.json from uuidv4 to uuid version 11.0.2.
  • Added a new test case in bigint.test.ts to verify multiplication with default settings.
  • Improved rounding logic in bigint.ts to use Math.round for better accuracy.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@moldy530 moldy530 requested a review from rthomare as a code owner November 7, 2024 16:31
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:07pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 5:07pm

Copy link
Collaborator Author

moldy530 commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @moldy530 and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator Author

moldy530 commented Nov 7, 2024

Merge activity

  • Nov 7, 1:00 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 7, 1:01 PM EST: A user merged this pull request with Graphite.

@moldy530 moldy530 merged commit 217443f into main Nov 7, 2024
7 checks passed
@moldy530 moldy530 deleted the moldy/fix-bigint-multiply branch November 7, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants