Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement RNSigner class #1161

Merged
merged 2 commits into from
Nov 19, 2024
Merged

feat: implement RNSigner class #1161

merged 2 commits into from
Nov 19, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Nov 18, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the RNSignerClient and related components by integrating Zod for better type validation, modifying user authentication settings, and improving the structure of exported types from various modules.

Detailed summary

  • Updated repoRoot path in metro.config.js.
  • Changed setUserAuthenticationRequired from true to false in NativeTEKStamperModule.kt.
  • Refactored exports in index.ts to include SessionManagerParamsSchema.
  • Added Zod validation in client.ts for RNSignerClientParamsSchema.
  • Adjusted constructor in RNSignerClient to parse parameters using Zod.
  • Introduced RNAlchemySignerParamsSchema and refactored RNAlchemySigner to utilize Zod for validation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:43pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:43pm

Copy link

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

iykazrji commented Nov 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iykazrji iykazrji changed the title feat: update type definitions for consistency feat: implement RN Nov 18, 2024
@iykazrji iykazrji changed the title feat: implement RN feat: implement RNSigner class Nov 18, 2024
@iykazrji iykazrji marked this pull request as ready for review November 18, 2024 19:47
account-kit/rn-signer/src/signer.ts Outdated Show resolved Hide resolved
account-kit/rn-signer/src/signer.ts Outdated Show resolved Hide resolved
account-kit/rn-signer/src/signer.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@moldy530 moldy530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than nit about schema definition for client

connection: ConnectionConfig;
rootOrgId?: string;
};
export const RNSignerClientParamsSchema = z.object({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should then consume this schema in the constructor below

@moldy530 moldy530 merged commit 90ad664 into moldy/rn-base Nov 19, 2024
6 of 7 checks passed
@moldy530 moldy530 deleted the iyk/rn-signer branch November 19, 2024 21:42
moldy530 pushed a commit that referenced this pull request Nov 20, 2024
* feat: update type definitions for consistency

* feat: update client constructor to parse params based on schema
moldy530 pushed a commit that referenced this pull request Nov 22, 2024
* feat: update type definitions for consistency

* feat: update client constructor to parse params based on schema
moldy530 pushed a commit that referenced this pull request Dec 2, 2024
* feat: update type definitions for consistency

* feat: update client constructor to parse params based on schema
moldy530 added a commit that referenced this pull request Dec 2, 2024
* chore(rn): create example from template

* feat(rn-signer): add key pair generation in android

* feat(rn): add bundle injection logic

* feat(rn): add stamping logic to android stamper

* fix(rn): get login working e2e

* refactor(rn): clean things up so they're more digestable

* chore: update github actions for rn

* feat: add a global polyfill for react-native-mmkv (#1159)

# Pull Request Checklist

- [ ] Did you add new tests and confirm existing tests pass? (`yarn test`)
- [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md))
- [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard?
- [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`)
- [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`)
- [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?

* feat: implement signer `create` and `disconnect` methods (#1152)

* feat: implement RNSigner class (#1161)

* feat: update type definitions for consistency

* feat: update client constructor to parse params based on schema

* chore: add example app to rn-base (#1171)

* fix: fix linting and spacing issues

* feat: remove package hoisting from example project

* fix: fix linting and spacing issues

* feat: add signer authentication sample implementation in example app

* feat: add tsx to handle server instantiation

* feat: update peer-dependencies for signer package

---------

Co-authored-by: Iyk Azorji <iykazorji@gmail.com>

* chore: update the gh action cache for yarn

* feat: update rn-signer readme to contain additional setup information (#1172)

---------

Co-authored-by: Iyk Azorji <iykazorji@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants