-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement RNSigner class #1161
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “graphite-merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
847ecd0
to
3711960
Compare
02633ee
to
9baed28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than nit about schema definition for client
a117464
to
162db38
Compare
connection: ConnectionConfig; | ||
rootOrgId?: string; | ||
}; | ||
export const RNSignerClientParamsSchema = z.object({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should then consume this schema in the constructor below
* feat: update type definitions for consistency * feat: update client constructor to parse params based on schema
* feat: update type definitions for consistency * feat: update client constructor to parse params based on schema
* feat: update type definitions for consistency * feat: update client constructor to parse params based on schema
* chore(rn): create example from template * feat(rn-signer): add key pair generation in android * feat(rn): add bundle injection logic * feat(rn): add stamping logic to android stamper * fix(rn): get login working e2e * refactor(rn): clean things up so they're more digestable * chore: update github actions for rn * feat: add a global polyfill for react-native-mmkv (#1159) # Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? * feat: implement signer `create` and `disconnect` methods (#1152) * feat: implement RNSigner class (#1161) * feat: update type definitions for consistency * feat: update client constructor to parse params based on schema * chore: add example app to rn-base (#1171) * fix: fix linting and spacing issues * feat: remove package hoisting from example project * fix: fix linting and spacing issues * feat: add signer authentication sample implementation in example app * feat: add tsx to handle server instantiation * feat: update peer-dependencies for signer package --------- Co-authored-by: Iyk Azorji <iykazorji@gmail.com> * chore: update the gh action cache for yarn * feat: update rn-signer readme to contain additional setup information (#1172) --------- Co-authored-by: Iyk Azorji <iykazorji@gmail.com>
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the
RNSignerClient
and related components by integrating Zod for better type validation, modifying user authentication settings, and improving the structure of exported types from various modules.Detailed summary
repoRoot
path inmetro.config.js
.setUserAuthenticationRequired
fromtrue
tofalse
inNativeTEKStamperModule.kt
.index.ts
to includeSessionManagerParamsSchema
.client.ts
forRNSignerClientParamsSchema
.RNSignerClient
to parse parameters using Zod.RNAlchemySignerParamsSchema
and refactoredRNAlchemySigner
to utilize Zod for validation.