Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: entry point address as optional to SmartContractAccount #182

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: entry point address as optional to SmartContractAccount #182

merged 1 commit into from
Oct 31, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Oct 30, 2023 •
edited by pr-codex bot
Loading

app.asana.com/0/1205598840815267/1205773893380310/f

Made to make entry point contract address param for SmartContractAccount class as optional (in case user wants to use their own for some reason).

Also, fixed some .gitignore issues. cc: @moldy530

PR-Codex overview

Detailed summary

  • Updated the factoryAddress parameter in multiple files to use the getDefaultLightAccountFactoryAddress function from @alchemy/aa-accounts instead of hardcoding the address.
  • Updated the factoryAddress parameter in multiple files to use the getDefaultSimpleAccountFactoryAddress function from @alchemy/aa-core instead of hardcoding the address.
  • Removed unused imports and variables.

The following files were skipped due to too many changes: site/snippets/ethers-signer.ts, packages/alchemy/e2e-tests/simple-account.test.ts, packages/ethers/e2e-tests/simple-account.test.ts, packages/core/src/account/__tests__/simple.test.ts, packages/core/e2e-tests/simple-account.test.ts, site/snippets/account-core.ts, site/snippets/light-account.ts, site/snippets/provider.ts, packages/accounts/src/kernel-zerodev/__tests__/account.test.ts, packages/core/src/account/base.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon force-pushed the denniswon/abstract-entrypoint branch from bc2e02b to f2717f8 Compare October 30, 2023 02:59
@denniswon denniswon changed the base branch from denniswon/abstract-entrypoint to denniswon/entrypoint-validation October 30, 2023 03:03
@denniswon denniswon force-pushed the denniswon/abstract-entrypoint-sca branch from f6a805a to 93252b9 Compare October 30, 2023 03:03
@denniswon denniswon force-pushed the denniswon/entrypoint-validation branch from ecf61aa to 5c36999 Compare October 30, 2023 03:33
@denniswon denniswon force-pushed the denniswon/abstract-entrypoint-sca branch from 93252b9 to e7a39f5 Compare October 30, 2023 03:36
@denniswon denniswon changed the title feat: make entry point contract as an optional param to SCA class feat: entry point address as optional to SmartContractAccount Oct 30, 2023
avasisht23
avasisht23 reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments 🙏 overall lgtm, small discussion points

packages/core/src/account/base.ts Outdated Show resolved Hide resolved
packages/core/src/account/base.ts Outdated Show resolved Hide resolved
packages/core/src/account/base.ts Outdated Show resolved Hide resolved
packages/core/src/account/base.ts Outdated Show resolved Hide resolved
packages/core/src/account/base.ts Show resolved Hide resolved
@denniswon denniswon force-pushed the denniswon/entrypoint-validation branch from c8f5c1d to 9194213 Compare October 30, 2023 23:32
@denniswon denniswon force-pushed the denniswon/abstract-entrypoint-sca branch 4 times, most recently from 02961ae to 0317d23 Compare October 31, 2023 01:45
@denniswon denniswon changed the base branch from denniswon/entrypoint-validation to development October 31, 2023 01:46
@denniswon denniswon force-pushed the denniswon/abstract-entrypoint-sca branch from 0317d23 to 21008d9 Compare October 31, 2023 01:49
@denniswon denniswon force-pushed the denniswon/abstract-entrypoint-sca branch from 21008d9 to 9195ad0 Compare October 31, 2023 01:51
@denniswon denniswon merged commit 63846cb into development Oct 31, 2023
3 checks passed
@denniswon denniswon deleted the denniswon/abstract-entrypoint-sca branch October 31, 2023 01:54
avasisht23 pushed a commit that referenced this pull request Nov 3, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
4d44a6a
avasisht23 pushed a commit that referenced this pull request Nov 3, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
14019a4
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
moldy530 pushed a commit that referenced this pull request Nov 10, 2023
@denniswon @moldy530
feat: make entry point contract as an optional param to SCA class (#182)
3084ad5
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
avasisht23 pushed a commit that referenced this pull request Nov 14, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
93ebb49
avasisht23 pushed a commit that referenced this pull request Nov 14, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
129a346
denniswon added a commit that referenced this pull request Nov 16, 2023
@denniswon
feat: make entry point contract as an optional param to SCA class (#182)
e80b008
moldy530 pushed a commit that referenced this pull request Nov 16, 2023
@denniswon @moldy530
feat: make entry point contract as an optional param to SCA class (#182)
43581c6
@moldy530 moldy530 mentioned this pull request Nov 17, 2023
Merged
7 tasks
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
Merged
8 tasks
avasisht23 pushed a commit that referenced this pull request Dec 3, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
b442e93
avasisht23 pushed a commit that referenced this pull request Dec 3, 2023
@denniswon @avasisht23
feat: make entry point contract as an optional param to SCA class (#182)
a9f3def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avasisht23 avasisht23 avasisht23 left review comments

@moldy530 moldy530 moldy530 approved these changes

@rthomare rthomare Awaiting requested review from rthomare rthomare is a code owner

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@mokok123 mokok123 Awaiting requested review from mokok123 mokok123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denniswon @moldy530 @avasisht23