-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use alchemy provider, light account for e2e tests #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
November 3, 2023 20:56
denniswon
force-pushed
the
denniswon/e2e
branch
2 times, most recently
from
November 3, 2023 21:33
edf9b7d
to
a13f1b7
Compare
avasisht23
force-pushed
the
development
branch
from
November 3, 2023 21:36
9d7a15f
to
a886853
Compare
Are all the changes in this PR relevant? Seems like it includes way more than e2e updates? |
sorry @denniswon I just rebased dev on main after pulling in the changes for a new version. make sure to rebase this PR on dev again |
denniswon
force-pushed
the
denniswon/e2e
branch
2 times, most recently
from
November 3, 2023 23:06
e417413
to
d9a1161
Compare
moldy530
reviewed
Nov 3, 2023
denniswon
force-pushed
the
denniswon/e2e
branch
3 times, most recently
from
November 5, 2023 19:39
145186f
to
28fbf96
Compare
avasisht23
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, few nits
packages/accounts/src/light-account/e2e-tests/light-account.test.ts
Outdated
Show resolved
Hide resolved
denniswon
force-pushed
the
denniswon/e2e
branch
2 times, most recently
from
November 6, 2023 00:30
f5b37fb
to
1cd86c5
Compare
denniswon
force-pushed
the
denniswon/e2e
branch
2 times, most recently
from
November 6, 2023 00:32
df37bf1
to
50b87dc
Compare
denniswon
force-pushed
the
denniswon/e2e
branch
2 times, most recently
from
November 6, 2023 01:14
cc69c0a
to
b34d1d3
Compare
denniswon
force-pushed
the
denniswon/e2e
branch
from
November 6, 2023 01:31
b34d1d3
to
edee99f
Compare
Merged
moldy530
pushed a commit
that referenced
this pull request
Nov 10, 2023
avasisht23
pushed a commit
that referenced
this pull request
Nov 14, 2023
avasisht23
pushed a commit
that referenced
this pull request
Nov 14, 2023
denniswon
added a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use AlchemyProvider with gas manager for all our e2e tests to less make it flaky.
Also, use light accounts unless for simple account tests.
For Kernel, just utilizing fee data getter override to set test passing variables.
PR-Codex overview
Detailed summary
@alchemy/aa-alchemy
as a devDependency inpackages/accounts/package.json
.constants.ts
files in various packages to include new environment variables and remove unnecessary ones.base.ts
inpackages/core/src/provider
to useconst
instead oflet
formaxPriorityFeePerGasBid
.sepolia
chain instead ofpolygonMumbai
.withFeeDataGetter.md
insite/packages/aa-core/provider
to use new fee values.simple-account.test.ts
files to usesepolia
chain instead ofpolygonMumbai
.kernel-account.test.ts
file to useMUMBAI_RPC_URL
instead ofRPC_URL
.simple-account.test.ts
file to useMUMBAI_RPC_URL
instead ofRPC_URL
.light-account.test.ts
file to useAlchemyProvider
from@alchemy/aa-alchemy
andLightSmartContractAccount
from../../index.js
.