Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: aa-sdk with native arb sepolia support #231

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: aa-sdk with native arb sepolia support #231

merged 1 commit into from
Nov 9, 2023

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Nov 9, 2023 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR adds support for the arbitrumSepolia chain in the getDefaultLightAccountFactoryAddress and getDefaultSimpleAccountFactoryAddress functions.

Detailed summary

  • Added arbitrumSepolia to the getDefaultLightAccountFactoryAddress function.
  • Added arbitrumSepolia to the getDefaultSimpleAccountFactoryAddress function.
  • Updated the deployment addresses documentation to include arbitrumSepolia in the Light Account and Simple Account sections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon marked this pull request as draft November 9, 2023 17:22
@denniswon
Copy link
Contributor Author

Blocked until arb sepolia light account factory is deployed.
https://alchemyinsights.slack.com/archives/C05JH7SEXGA/p1699550589114189?thread_ts=1699545776.361749&cid=C05JH7SEXGA

@denniswon denniswon marked this pull request as ready for review November 9, 2023 17:30
@denniswon
Copy link
Contributor Author

https://alchemyinsights.slack.com/archives/C05JH7SEXGA/p1699550922618609?thread_ts=1699545776.361749&cid=C05JH7SEXGA

LightAccount deployment done: https://sepolia.arbiscan.io/tx/0x462b5da404cb8f23509c0928be65a6b19dfd08f482604424fb328f6a1c28ab29#internal

@denniswon denniswon merged commit 7580608 into development Nov 9, 2023
3 checks passed
@denniswon denniswon deleted the denniswon/arb-sepolia branch November 9, 2023 18:34
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
moldy530 pushed a commit that referenced this pull request Nov 10, 2023
@denniswon @moldy530
feat: aa-sdk with native arb sepolia support (#231)
f67ad6c
@moldy530 moldy530 mentioned this pull request Nov 10, 2023
Merged
avasisht23 pushed a commit that referenced this pull request Nov 14, 2023
@denniswon @avasisht23
feat: aa-sdk with native arb sepolia support (#231)
1bb816a
avasisht23 pushed a commit that referenced this pull request Nov 14, 2023
@denniswon @avasisht23
feat: aa-sdk with native arb sepolia support (#231)
737f9c4
denniswon added a commit that referenced this pull request Nov 16, 2023
@denniswon
feat: aa-sdk with native arb sepolia support (#231)
1af5f81
moldy530 pushed a commit that referenced this pull request Nov 16, 2023
@denniswon @moldy530
feat: aa-sdk with native arb sepolia support (#231)
acfb54a
@moldy530 moldy530 mentioned this pull request Nov 17, 2023
Merged
7 tasks
@moldy530 moldy530 mentioned this pull request Dec 1, 2023
Merged
8 tasks
avasisht23 pushed a commit that referenced this pull request Dec 3, 2023
@denniswon @avasisht23
feat: aa-sdk with native arb sepolia support (#231)
5b370ee
avasisht23 pushed a commit that referenced this pull request Dec 3, 2023
@denniswon @avasisht23
feat: aa-sdk with native arb sepolia support (#231)
13588f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@moldy530 moldy530 Awaiting requested review from moldy530 moldy530 is a code owner

@rthomare rthomare Awaiting requested review from rthomare rthomare is a code owner

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@mokok123 mokok123 Awaiting requested review from mokok123 mokok123 is a code owner

@avasisht23 avasisht23 Awaiting requested review from avasisht23

@dphilipson dphilipson Awaiting requested review from dphilipson

@jaypaik jaypaik Awaiting requested review from jaypaik

@fangting-alchemy fangting-alchemy Awaiting requested review from fangting-alchemy

@adam-alchemy adam-alchemy Awaiting requested review from adam-alchemy

@howydev howydev Awaiting requested review from howydev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denniswon @0xfourzerofour