Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: dfns new signer #313

Merged
merged 21 commits into from
Dec 12, 2023
Merged

docs: dfns new signer #313

merged 21 commits into from
Dec 12, 2023

Conversation

avarobinson
Copy link
Collaborator

@avarobinson avarobinson commented Dec 11, 2023

Pull Request Checklist


PR-Codex overview

Detailed summary

  • Added a new page for "Dfns" in the site navigation
  • Removed specific wallet signers from the "Signers" section in the introduction page and replaced them with a link to the "Choosing a Signer" page
  • Updated the "Supported Signers" page to remove specific wallet signers and added a link to the "Choosing a Signer" page
  • Added a new file for the Dfns integration guide
  • Added code snippets for initializing and using the Dfns signer in the Dfns integration guide
  • Updated the "Why Account Kit" page to remove specific wallet signers and added a link to the "Choosing a Signer" page
  • Updated the code example in the "Use it with Light Account" section in the Dfns integration guide to use the createDfnsSigner function
  • Added new imports and code for the Dfns signer in the snippets/dfns.ts file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just some small changes before a stamp.

can you make sure there's nowhere else they need to add themselves?

for instance, I see signers add themselves to site/smart-accounts/overview.md as well.

site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
site/smart-accounts/signers/guides/dfns.md Outdated Show resolved Hide resolved
avarobinson and others added 11 commits December 11, 2023 11:22
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
site/snippets/dfns.ts Outdated Show resolved Hide resolved
avasisht23
avasisht23 previously approved these changes Dec 11, 2023
Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last few nits.

also, do you want to add them to overview.md or anything else? otherwise, feel free to ship after these last changes.

avarobinson and others added 3 commits December 11, 2023 15:51
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
avarobinson and others added 2 commits December 11, 2023 15:51
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
Co-authored-by: Ajay Vasisht <43521356+avasisht23@users.noreply.github.com>
@avarobinson
Copy link
Collaborator Author

last few nits.

also, do you want to add them to overview.md or anything else? otherwise, feel free to ship after these last changes.

Don't think signers are added individually anywhere else? Don't see this in overview.md

Copy link
Contributor

@avasisht23 avasisht23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@avasisht23 avasisht23 merged commit 33141b0 into main Dec 12, 2023
2 checks passed
@avasisht23 avasisht23 deleted the signer/dfns branch December 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants