Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a factory method for session key accounts #369

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Jan 17, 2024

Pull Request Checklist


PR-Codex overview

Detailed summary

  • Added createMultiOwnerMSCAWithSessionKey function to create a new MSCA account with a session key signer and fallback signer.
  • Updated imports and dependencies in various files.
  • Added SessionKeyExecutor and SessionKeySigner to the list of imports in multi-owner-account.ts file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@moldy530 moldy530 force-pushed the moldy/session-key-acct-factory branch from 93bdc2a to 1412092 Compare January 17, 2024 00:05
@moldy530 moldy530 force-pushed the moldy/session-key-signer branch 2 times, most recently from 9b74855 to 6325572 Compare January 17, 2024 01:10
@moldy530 moldy530 force-pushed the moldy/session-key-acct-factory branch from 1412092 to 48cd6f0 Compare January 17, 2024 01:12
denniswon
denniswon previously approved these changes Jan 17, 2024
@moldy530 moldy530 force-pushed the moldy/session-key-signer branch 2 times, most recently from 6881549 to 0033fd5 Compare January 17, 2024 16:20
@moldy530 moldy530 force-pushed the moldy/session-key-acct-factory branch from 48cd6f0 to c93470f Compare January 17, 2024 16:23
@moldy530 moldy530 force-pushed the moldy/session-key-signer branch from 0033fd5 to 16cd596 Compare January 17, 2024 18:07
Base automatically changed from moldy/session-key-signer to main January 17, 2024 18:07
@moldy530 moldy530 dismissed denniswon’s stale review January 17, 2024 18:07

The base branch was changed.

@moldy530 moldy530 force-pushed the moldy/session-key-acct-factory branch from c93470f to ebb44da Compare January 17, 2024 18:09
@moldy530 moldy530 merged commit 58658ee into main Jan 17, 2024
1 of 2 checks passed
@moldy530 moldy530 deleted the moldy/session-key-acct-factory branch January 17, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants