Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a couple of the package.jsons #374

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: fix a couple of the package.jsons #374

merged 1 commit into from
Jan 22, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Jan 22, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the devDependencies in the package.json files.

Detailed summary

  • Updated the version of @alchemy/aa-accounts in the packages/alchemy/package.json file to *
  • Removed the dependency on @alchemy/aa-core in the packages/accounts/package.json file
  • Updated the version of @wagmi/cli to ^1.5.2 in the packages/accounts/package.json file
  • Updated the version of change-case to ^5.1.2 in the packages/accounts/package.json file
  • Updated the version of dedent to ^1.5.1 in the packages/accounts/package.json file
  • Added the dependency on typescript with version ^5.0.4 in the packages/alchemy/package.json file
  • Added the dependency on typescript-template with version * in the packages/alchemy/package.json file
  • Updated the version of vitest to ^0.31.0 in the packages/alchemy/package.json file

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@@ -52,7 +52,6 @@
"test:run-e2e": "vitest run --config vitest.config.e2e.ts"
},
"devDependencies": {
"@alchemy/aa-core": "^2.1.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already a dependency

@@ -39,8 +39,7 @@
"test:run-e2e": "vitest run --config vitest.config.e2e.ts"
},
"devDependencies": {
"@alchemy/aa-accounts": "^2.1.0",
"@alchemy/aa-core": "^2.1.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so is this one

@@ -39,8 +39,7 @@
"test:run-e2e": "vitest run --config vitest.config.e2e.ts"
},
"devDependencies": {
"@alchemy/aa-accounts": "^2.1.0",
"@alchemy/aa-core": "^2.1.0",
"@alchemy/aa-accounts": "*",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make it so lerna just takes whatever is available locally

@denniswon denniswon merged commit 7abbd93 into main Jan 22, 2024
1 of 2 checks passed
@denniswon denniswon deleted the moldy/fix-pkgjson branch January 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants