Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update session key plugindef abi and config #382

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

denniswon
Copy link
Contributor

@denniswon denniswon commented Jan 25, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the contract instances and adding type definitions for the getContract method in the session-key, multi-owner, and token-receiver plugins.

Detailed summary

  • Updated the getContract method in the session-key, multi-owner, and token-receiver plugins to include the rpcClient parameter.
  • Added type definitions for the PublicErc4337Client, HttpTransport, and Transport types.
  • Updated the getContract method in the plugin generator to include the rpcClient parameter.
  • Updated the getContract method in the multi-owner and token-receiver plugins to include the rpcClient parameter.
  • Updated the accountMethods in the session-key plugin to include the isAccountSessionKey, getAccountSessionKeys, removeAccountSessionKey, and clearAccountSessionKeys methods.
  • Updated the providerMethods in the session-key plugin to include the removeAccountSessionKey method.

The following files were skipped due to too many changes: packages/accounts/src/msca/plugins/session-key/SessionKeyPermissionsUpdatesAbi.ts, packages/accounts/plugindefs/token-receiver/abi.ts, packages/accounts/plugindefs/multi-owner/abi.ts, packages/accounts/src/msca/plugins/session-key/plugin.ts, packages/accounts/plugindefs/session-key/abi.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@denniswon denniswon force-pushed the denniswon/session-key-abi-update branch 2 times, most recently from 211cd20 to b31a2bf Compare January 25, 2024 20:11
@denniswon denniswon force-pushed the denniswon/session-key-abi-update branch from b31a2bf to 7117d2a Compare January 26, 2024 02:06
@denniswon denniswon marked this pull request as ready for review January 26, 2024 02:07
@denniswon denniswon merged commit a47978e into main Jan 26, 2024
2 checks passed
@denniswon denniswon deleted the denniswon/session-key-abi-update branch January 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants