feat: kernel batch transactions and gas estimation fixes #39
Conversation
# Conflicts: # packages/core/src/index.ts
…r `KernelSmartAccountProvider`
…r `KernelSmartAccountProvider`
| ); | ||
|
|
||
| estimates.verificationGasLimit = | ||
| (BigInt(estimates.verificationGasLimit) * 130n) / 100n; |
There was a problem hiding this comment.
I didn't have accurate answer to your question about requiring 30% extra gas usage for kernel. Turns out, it was because i added an inaccurate dummy signature which leads to underestimation of gas. Fixed in this update
|
Build will only pass once new version from main branch is released |
|
ah nice good catch! will let you know once I push an update |
|
@ManaOmlabs sorry for the delay here, was trying to automate deploys somewhat. That's all working now and the latest version should be published! |
# Conflicts: # packages/accounts/package.json
whatmanathinks
changed the title
|
@moldy530 ready to review |
| @@ -198,22 +196,31 @@ describe("Kernel Account Tests", () => { | |||
| // await expect(result).resolves.not.toThrowError(); | |||
| // }); | |||
|
|
|||
| // it("sendUserOperation batch should execute properly", async () => { | |||
There was a problem hiding this comment.
@ManaOmlabs , the aa infra on alchemy is now open to the public so it should be possible to make these tests pass here. However, @avasisht23 is working on splitting tests into integration vs unit tests so we'll make sure to port these over as integration tests since they require an alchemy api key
There was a problem hiding this comment.
Sure thing. I will be on lookout for the respective PR
| } | ||
| // @ts-ignore |
There was a problem hiding this comment.
can we make this @ts-ignore: <reason for ignore> also we shouldn't use @ts-ignore and instead use @ts-expect-error
| [ | ||
| call.delegateCall ? 1 : 0, | ||
| call.target, | ||
| call.value || BigInt(0), |
There was a problem hiding this comment.
nit:
| call.value || BigInt(0), | |
| call.value ?? BigInt(0), |
|
@moldy530 let me know if any more changes needed |
| ): Promise<`0x${string}`> { | ||
| // @ts-ignore | ||
| const multiSendData: `0x${string}` = | ||
| "0x" + _txs.map((tx) => encodeCall(tx)).join(""); |
There was a problem hiding this comment.
Btw you could use the concat util from viem and just do
concat(_txs.map(...))
| override async encodeBatchExecute( | ||
| _txs: BatchUserOperationCallData | ||
| ): Promise<`0x${string}`> { | ||
| // @ts-ignore |
| } | ||
| // @ts-expect-error: signWith6492 exists only on kernel account which is expected |
There was a problem hiding this comment.
Oh you could fix this by either overriding the account param on the kernel provider so it has more specific typing or making the provider take a generic A extends BaseSmartContractAccount = BaseSmartContractAccount
|
@moldy530 everything handled :) |
docs: start adding utils docs
No description provided.