fix: headers fix #484
Merged
fix: headers fix #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepegler
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
Fixes issue: alchemyplatform#472 fix: custom headers fix
moldy530
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR didn't cover all areas where alchemy's headers are set: #475
It resolves this issue: #472
PR-Codex overview
This PR updates the
headersobject inbase.tsin thecorepackage to conditionally include theAlchemy-Aa-Sdk-Signerbased on therpcUrl.Detailed summary
Alchemy-Aa-Sdk-Signerbased onrpcUrlcontaining "alchemy"headersobject for conditional inclusion