-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: paymaster middleware update per entrypoint v7 user operation #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniswon
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
April 16, 2024 00:55
denniswon
force-pushed
the
denniswon/entrypoint-v7-paymaster-core
branch
from
April 16, 2024 01:49
1915607
to
6e926f1
Compare
dphilipson
previously approved these changes
Apr 16, 2024
denniswon
force-pushed
the
denniswon/entrypoint-v7-paymaster-core
branch
5 times, most recently
from
April 16, 2024 21:24
73a0b9b
to
6a128e4
Compare
avasisht23
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high level comments and this overall looks good, but would love comments from @dphilipson too!
site/packages/aa-core/smart-account-client/types/userOperationOverrides.md
Outdated
Show resolved
Hide resolved
site/packages/aa-core/smart-account-client/types/userOperationOverrides.md
Outdated
Show resolved
Hide resolved
dphilipson
reviewed
Apr 16, 2024
denniswon
force-pushed
the
denniswon/entrypoint-v7-paymaster-core
branch
3 times, most recently
from
April 17, 2024 04:36
388ecfe
to
1709533
Compare
@avasisht23 @dphilipson could you please give another look on this PR? thanks |
dphilipson
previously approved these changes
Apr 17, 2024
denniswon
force-pushed
the
denniswon/entrypoint-v7-paymaster-core
branch
from
April 17, 2024 23:41
672e42a
to
bb2a161
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR updates package versions and adds support for
EntryPointVersion
in various files.Detailed summary
3.8.2-alpha.0
EntryPointVersion
in multiple filesUserOperationFeeOptions