feat: add frax and zora defaults #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-miao
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
avasisht23 and
denniswon
as code owners
alex-miao
force-pushed
the
alex/frax-zora
branch
from
4828332 to
67b8b9f
Compare
alex-miao
commented
Apr 22, 2024
denniswon
reviewed
Apr 22, 2024
Comment on lines
+32
to
+35
| [fraxtal.id]: "0x000000000000A53f64b7bcf4Cd59624943C43Fc7", | ||
| [fraxtalTestnet.id]: "0x000000000000A53f64b7bcf4Cd59624943C43Fc7", | ||
| [zora.id]: "0x000000000000A53f64b7bcf4Cd59624943C43Fc7", | ||
| [zoraSepolia.id]: "0x000000000000A53f64b7bcf4Cd59624943C43Fc7", |
There was a problem hiding this comment.
are our 4 plugins deployed and available in all these chains? cc: @adam-alchemy
moldy530
reviewed
Apr 23, 2024
alex-miao
force-pushed
the
alex/frax-zora
branch
from
cf1db9f to
fe0cd08
Compare
moldy530
reviewed
Apr 24, 2024
There was a problem hiding this comment.
LGTM, but we should add a doc that explains how someone might use Zora or Frax. Namely, they will need to set the RPC url in their transport (or for AlchemyClient the rpcUrl property) to be their backend which should handle splitting traffic to our bundler and their node url of choice.
We'll follow up and add better split traffic support to the alchemy smart account client
moldy530
reviewed
Apr 26, 2024
site/third-party/bundlers.md
Outdated
|
|
||
| ## Zora and Fraxtal | ||
|
|
||
| Using a split Bundler and Node RPC setup is required for Fraxtal, Fraxtal Testnet, Zora, and Zora Sepolia networks since Alchemy currently only supports Account Abstraction endpoints for those networks. |
There was a problem hiding this comment.
do we have any suggested 3rd party providers for RPC for theses chains? might be helpful to link out to them here
There was a problem hiding this comment.
Good idea, added links
moldy530
previously approved these changes
Apr 26, 2024
moldy530
approved these changes
Apr 26, 2024
moldy530
pushed a commit
that referenced
this pull request
Apr 30, 2024
* feat: add frax and zora defaults * fix: fix imports * refactor: import zora and frax from aa-core * docs: add doc section on zora and frax * docs: add zora and frax rpc docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
Focus: Introducing support for Fraxtal, Fraxtal Testnet, Zora, and Zora Sepolia networks in the Alchemy platform.
Detailed summary
fraxtal,fraxtalTestnet,zora, andzoraSepoliachains