fix: determine entry point version from light account version #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphilipson
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
avasisht23
as code owners
dphilipson
commented
Apr 30, 2024
| entryPoint = getEntryPoint(chain), | ||
| entryPoint = getEntryPoint(chain, { | ||
| version: AccountVersionRegistry["LightAccount"][version] | ||
| .entryPointVersion as any, |
There was a problem hiding this comment.
I couldn't think of a way to do this without the any cast. TypeScript can't infer that this type matches the type for the light account version in version.
There was a problem hiding this comment.
is GetLightAccountVersion generic on entrypoint version? it could take in the TEntryPointVersion which might strongly type them
There was a problem hiding this comment.
oh wait:
TEntryPointVersion extends GetEntryPointForLightAccountVersion<
"LightAccount",
TLightAccountVersion
> = GetEntryPointForLightAccountVersion<"LightAccount", TLightAccountVersion>
weird. I'd expect this to allow the inference
There was a problem hiding this comment.
Yeah, I'm not quite sure why either, but the error message is a bit too complicated to easily decipher 😞.
moldy530
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates the
entryPointinitialization in theaccount.tsfile to include the version fromAccountVersionRegistry.Detailed summary
entryPointinitialization to include version fromAccountVersionRegistryAccountVersionRegistryto fetch version and address information forLightAccount