fix: waitForUserOperationTx parameters were incorrect #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldy530
requested review from
rthomare,
dancoombs,
mokok123,
avasisht23 and
dphilipson
as code owners
avasisht23
reviewed
Apr 30, 2024
| @@ -86,6 +86,25 @@ export type DropAndReplaceUserOperationParameters< | |||
| //#region WaitForUserOperationTxParameters | |||
| export type WaitForUserOperationTxParameters = { | |||
| hash: Hex; | |||
| /** | |||
There was a problem hiding this comment.
Do you want to reuse these from the client opts schema?
There was a problem hiding this comment.
I did, but then didn't want to perpetuate zod cuz it's annoying in some places
| for (let i = 0; i < client.txMaxRetries; i++) { | ||
| const { | ||
| hash, | ||
| retries = { |
There was a problem hiding this comment.
If these aren't provided is this going to use what the client passes in? I don't see that in the diff
There was a problem hiding this comment.
yea that's what this line does, the destructue with the equals is setting the default value if it's not passed in
avasisht23
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR enhances the
waitForUserOperationTransactionfunction in the smart account module by adding support for custom exponential backoff parameters.Detailed summary
retriesobject toWaitForUserOperationTxParametersfor custom backoff settingswaitForUserOperationTransactionfunction to use custom backoff settings if provided