Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update light account dummy signature for v2 #662

Merged

Conversation

jaypaik
Copy link
Contributor

@jaypaik jaypaik commented May 9, 2024

Pull Request Checklist


PR-Codex overview

The focus of this PR is to update the LightAccount functionality to support different versions and improve testing coverage.

Detailed summary

  • Added switch statement in getDummySignature to handle different versions
  • Updated tests to cover different versions of LightAccount
  • Added LightAccountVersion type and AccountVersionRegistry
  • Improved handling of different versions in encodeUpgradeToAndCall and givenConnectedProvider

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jaypaik jaypaik merged commit 5ac35a3 into main May 9, 2024
3 checks passed
@jaypaik jaypaik deleted the 05-09-fix_update_light_account_dummy_signature_for_v2 branch May 9, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants