Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change email validation rule #710

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat: change email validation rule #710

merged 1 commit into from
Jun 11, 2024

Conversation

tinaszheng
Copy link
Contributor

@tinaszheng tinaszheng commented Jun 10, 2024

We should only enable the "Submit" button if the email is valid - therefore we don't need the error state anymore 🤔
https://www.figma.com/design/5n3ACN3Z6PJjULtfXux5ay?node-id=19-2593#829800061

Pull Request Checklist


PR-Codex overview

The focus of this PR is to update the EmailAuth component in the EmailAuth.tsx file to improve email validation and button disabling logic.

Detailed summary

  • Updated validation trigger from onBlur to onChange for email input
  • Removed error display logic
  • Modified button disabled condition to also check for email presence

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 5:07pm

@tinaszheng tinaszheng merged commit f869f5e into main Jun 11, 2024
5 checks passed
@tinaszheng tinaszheng deleted the tina/email branch June 11, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants