-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom theme switch component #726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tinaszheng
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
June 17, 2024 15:37
tinaszheng
changed the title
feat: Add custom theme switch component
feat: add custom theme switch component
Jun 17, 2024
bswags
approved these changes
Jun 17, 2024
@layer utilities { | ||
.text-balance { | ||
text-wrap: balance; | ||
@layer base { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could integrate w the above block but also not the worst to keep this separate
tinaszheng
added a commit
that referenced
this pull request
Jun 19, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Jun 25, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Jun 25, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Jun 28, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Jul 17, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Jul 30, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Aug 13, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
moldy530
pushed a commit
that referenced
this pull request
Aug 28, 2024
* feat: add custom theme switch * fix: undo lockfile changes * feat: update theme in global config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still waiting on designs for the "checked" version
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR updates the global CSS variables for light and dark themes, adds a new
ThemeSwitch
component, and integrates theme switching functionality.Detailed summary
ThemeSwitch
component for theme switchingStyling
component