Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move chain definitions out of aa-sdk core #772

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented Jun 21, 2024

Pull Request Checklist


PR-Codex overview

The focus of this PR is to refactor imports and dependencies across multiple files.

Detailed summary

  • Updated imports from @aa-sdk/core to @account-kit/infra
  • Refactored import statements for chains and plugins
  • Removed unnecessary imports and dependencies

The following files were skipped due to too many changes: account-kit/smart-contracts/src/light-account/clients/alchemyClient.ts, account-kit/smart-contracts/src/msca/client/multiSigAlchemyClient.ts, aa-sdk/core/src/utils/defaults.ts, account-kit/smart-contracts/src/light-account/clients/multiOwnerAlchemyClient.ts, aa-sdk/core/src/utils/index.ts, aa-sdk/core/src/account/__tests__/simple.test.ts, aa-sdk/core/src/index.ts, site/pages/migration-guides/migrating-to-v3.md, aa-sdk/ethers/src/__tests__/provider-adapter.test.ts, aa-sdk/ethers/src/provider-adapter.ts, account-kit/infra/src/chains.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:00pm

Dan-Nolan
Dan-Nolan previously approved these changes Jun 21, 2024
Copy link
Collaborator

@Dan-Nolan Dan-Nolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get those chains! ⛓️

@@ -51,7 +50,7 @@ export const getDefaultSimpleAccountFactoryAddress = (
case baseGoerli.id:
case baseSepolia.id:
case fraxtal.id:
case fraxtalSepolia.id:
case 2523:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not gonna put a comment here because we have an item to just delete this all together since we're gonna remove simple account from here

@moldy530 moldy530 merged commit d29dd4e into v4.x.x Jun 28, 2024
5 checks passed
@moldy530 moldy530 deleted the moldy/move-chain-defs branch June 28, 2024 16:14
moldy530 added a commit that referenced this pull request Jun 28, 2024
BREAKING CHANGE: moves the chain definitions out of aa-sdk core and into account-kit/infra
moldy530 added a commit that referenced this pull request Jul 17, 2024
BREAKING CHANGE: moves the chain definitions out of aa-sdk core and into account-kit/infra
moldy530 added a commit that referenced this pull request Jul 30, 2024
BREAKING CHANGE: moves the chain definitions out of aa-sdk core and into account-kit/infra
moldy530 added a commit that referenced this pull request Aug 13, 2024
BREAKING CHANGE: moves the chain definitions out of aa-sdk core and into account-kit/infra
moldy530 added a commit that referenced this pull request Aug 28, 2024
BREAKING CHANGE: moves the chain definitions out of aa-sdk core and into account-kit/infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate all of the alchemy chain configs from aa-sdk/core to account-kit/infra
3 participants