feat: add UI config defaults, better back navigation to auth UI #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bswags
requested review from
moldy530,
rthomare,
dancoombs,
mokok123 and
dphilipson
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bswags
commented
Jul 10, 2024
| @@ -49,7 +49,7 @@ export const AddPasskey = () => { | |||
| {BENEFITS.map(({ title, icon: Icon, description }) => ( | |||
| <div key={title} className="flex gap-2"> | |||
| <div className="h-5 w-5 flex items-center justify-center"> | |||
| <Icon illustrationStyle={illustrationStyle ?? "flat"} /> | |||
| <Icon illustrationStyle={illustrationStyle} /> | |||
There was a problem hiding this comment.
@moldy530 if you'd prefer I can move reading this from the hook into the icon components; it felt a bit weird to have icon components that read from a context to configure themselves but it could also be... not that weird, defer to you
There was a problem hiding this comment.
yea I was thinking about that too, but since all of the components we're building are meant to be used internally I think it's ok since it removes a good bit of boilerplate
bswags
force-pushed
the
brian/defaults-and-nav
branch
from
21fa358 to
da17037
Compare
moldy530
reviewed
Jul 12, 2024
| const canGoBack = useMemo(() => { | ||
| return ["email_verify"].includes(authStep.type); | ||
| return ["email_verify", "passkey_verify"].includes(authStep.type); | ||
| }, [authStep]); | ||
|
|
||
| const onBack = useCallback(() => { |
There was a problem hiding this comment.
we should also clear the QP (or at least the bundle QP)
moldy530
approved these changes
Jul 12, 2024
moldy530
pushed a commit
that referenced
this pull request
Jul 17, 2024
moldy530
pushed a commit
that referenced
this pull request
Jul 30, 2024
moldy530
pushed a commit
that referenced
this pull request
Aug 13, 2024
moldy530
pushed a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
useUiConfighook for reading the provided UI configuration from the context, we can use it as a central place to set some configuration defaults that will be shared across the UI components. This also allows us to have fewer optional/nullable values and results in cleaner code.Additionally, this PR cleans up the "go back" implementation in the auth components.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR updates how UI configurations are handled in the Account Kit React components.
Detailed summary