Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: swaps on some pairs are not possible from UI or via smart contract #38

Open
finite2 opened this issue Jul 3, 2021 · 2 comments
Open

Comments

@finite2
Copy link

finite2 commented Jul 3, 2021

Alcor is not allowing swaps on some pairs at certain prices.
At this moment in time it is not possible to swap WAX to SHE - this seems to be an issue with the smart contract with the UI reflecting its not possible! Note that SHE has a precision of 0 so can only be traded in whole number amounts.

Link to swaps page:

Example at the time of trying to swap:

WAX staked: 2884
SHE staked: 279
approx price: 2884/279 = 10.34 WAX for 1 SHE

Lets say we try to swap 12 WAX we expect the pool to update to

WAX staked: 2896
SHE staked: 278
approx price: 2896/278 = 10.41 WAX for 1 SHE

Since the new price after the swap is much less than 12 WAX this transaction should be possible.
However the ui is not allowing us to make this transaction (the button is disabled).
Similarly trying to make the transaction directly to the smart contract is also being rejected with the error assertion failure with message: available(0 SHE) is less than expected

@finite2
Copy link
Author

finite2 commented Jul 4, 2021

A similar issue seems to be that alcorammswap is unable to give change (refund remaining after rounding) this is a pretty bad issue for WAXSHE

@dougbutner
Copy link
Contributor

I believe that this issue was fixed, I may have raise the same issue with our zero precision token. I can see volume on the pair you are describing. Please close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants