Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageMath types #15

Open
amnipar opened this issue Mar 28, 2012 · 1 comment
Open

ImageMath types #15

amnipar opened this issue Mar 28, 2012 · 1 comment

Comments

@amnipar
Copy link
Contributor

amnipar commented Mar 28, 2012

Some ImageMath functions have type issues that are revealed by haddock documents. Like, findMinMaxMask uses BareImage. It is also dubious which images can (or should) be called with D8 images. In my documentation commit, I have already changed some functions (like sqrt) to accept D32 image only. Then addS is now for D32 only while it might be possible to use it for D8 - but there could be overflow problems. Suggest deciding this matter for every function.

As a side note, should we have a BinaryImage type (perhaps newtype of Image GrayScale D8) that would be the only image type accepted for masks and such, and could be produced by comparison operators?
@aleator
Copy link
Owner

aleator commented Jul 25, 2012

Just an update: Could you be more specific on what needs to be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleator @amnipar