Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What are the light colors for ambient? #23

Open
FannieZhao0317 opened this issue Sep 27, 2019 · 4 comments
Open

What are the light colors for ambient? #23

FannieZhao0317 opened this issue Sep 27, 2019 · 4 comments

Comments

@FannieZhao0317
Copy link

FannieZhao0317 commented Sep 27, 2019 •
edited
Loading

Should it be white light? (1, 1, 1)
@FannieZhao0317 FannieZhao0317 changed the title What are the light colors for ambient and reflection? What are the light colors for ambient? Sep 27, 2019
@wammies
Copy link

wammies commented Sep 27, 2019

It should be (0.1, 0.1, 0.1): #1

@FannieZhao0317
Copy link
Author

@wammies thank you!

@Everybody0523
Copy link

Is this true for both raycolor and the blinn_phong_shading files?

@abhimadan
Copy link
Collaborator

All your lighting calculations are done in blinn_phong_shading, so you shouldn't be doing anything with ambient light directly in raycolor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abhimadan @wammies @Everybody0523 @FannieZhao0317