-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messages sometimes stack up at the bottom #20
Comments
So the messages that get stuck are stuck on top of each other at the bottom, do the existing messages still move up? |
No they don't until the stacked messages are moved to their proper position again. Messages by other players solve this after a while and sending one yourself almost always solves it immediately. |
I don't have any way to reproduce this, can you try taking a screenshot and copying the contents of the client console next time this happens? |
Yeah it's more likely to happen on a weaker rig (like mine) as it has more framerate inconsistencies (which seems to create it somehow). I'll get a screenie next time it happens |
Given that this only happens during low framerates, I assume that the code during the render hook is being terminated in order to let the next frame render in a timely manner. That is the only reason that the motion and fade effects would stop early; if the code is terminated before updating the internal timers. Since it is time based, the framerate should not have any impact on it and even if the game freezes for the entire duration of the effect it should correct on the final frame. Regardless, measures need to be taken to make sure that the final values of the animation are set. |
@misterff1 Here's the file I messaged you about: https://raw.githubusercontent.com/alecxvs/UTChat/b7d8765fd3a0fd11db64f0c8ed1d99c4c73f069b/utchat/client/utchat.lua Replace your utchat.lua with that, you should get console messages on the client whenever the fade or motion bug occurs. If I'm right about the cause, you may stop getting fade or motion bugs altogether, but you should still get console messages. If that's the case, then we know this is a fix. |
I'm afraid it did not solve the issue. It still happens and no messages are sent to the console. |
I accidentally didn't complete the important bit of code, try this one: |
Still the same thing as my previous comment :/ |
Just out of wild curiosity, could you go into utchat.lua and find the two instances of {terminate = true} and change them to false? |
Just out of wild curiosity, how is it possible that this fixed it? :P |
It's based on the wild chance that the fade and motion issues are actually two separate problems. Unless this fixed the motion bug too, then I'm at a loss for words. |
Nope, it does not. was about to tell you that :) |
More specifically, I realized that there's a bug in the fade that causes it to destroy the fade format before setting the fade to the final amount. This wouldn't be a problem with a high framerate because it would be close enough to the end value that you wouldn't notice a difference. I have no idea what's causing the motion bug because it doesn't sound so simple, so that doesn't close this issue. |
yeah I see. Is it safe to just do terminate = false though? |
I'm not sure, I don't know why I added that to fade and not to motion. It was probably a quick fix to fade being weird, but I ironed out most of the fade issues by now anyways. It should be fine, but watch for possible performance issues. |
yeah I'll monitor that closely. so far it does not seem to drop performance any more that what's already happening because of the broadcasts :P |
I think I see what's causing motion to be buggy, and the verdict is that the code is terrible. I'll probably rewrite the motion format later. |
uh oh, we have a problem with this new version of utchat already lol . people relogged now and suddenly they chatted in normal chat again and this error gets thrown every time someone uses chat: terminate did not cause this. false or true does not make a difference for this. |
|
Sorry for the late response. I can do that, but the question is if that utchat.lua text you sent here actually adds anything to the one in the actual dowloadable build. If not, then there is no real issue here as I just reverted to the official one and had no error messages anymore. |
When framerate drops (at least then, not sure if there's other times that it happens too), the chat messages won't be pushed upwards to the right position, but hang at the bottom of the chat. Sending a message in chat seems to solve it and correct that by pushing it up to where it should be at that time. It's not a serious issue, but it does look ugly.
The text was updated successfully, but these errors were encountered: