Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize names over paths when searching #67

Closed
Gama11 opened this issue Nov 3, 2016 · 4 comments
Closed

Prioritize names over paths when searching #67

Gama11 opened this issue Nov 3, 2016 · 4 comments
Assignees
Labels

Comments

@Gama11
Copy link
Contributor

Gama11 commented Nov 3, 2016

The picture illustrates the issue nicely. I have to scroll way down the list to find haxe, which exactly matches my search term, because there are a whole bunch of other projects with that search term in their paths. Project names should have a higher priority than paths and an exact match like haxe should be at the top of the list.

I think this issue wasn't present in earlier versions. I guess paths probably weren't being taken into account then?

@alefragnani
Copy link
Owner

Hi @Gama11 ,

I tottaly agree with you, but I don't have control how the items are filtered/matched. It's built in VScode. I don't remember changing that, at least intentionally, but maybe this is being caused by the new way the list is presented, because of the new .vscode projects detection (which explicity tells to matchOnDetail, which means, the path).

I'm not in front my dev machine to test, but once available I will revert to an older version and if confirmed, I will update a patch.

Thanks for reporting 👍

@alefragnani alefragnani added the bug label Nov 4, 2016
@alefragnani alefragnani self-assigned this Nov 5, 2016
@Gama11
Copy link
Contributor Author

Gama11 commented Nov 5, 2016

Thanks for the quick fix!

@Gama11
Copy link
Contributor Author

Gama11 commented Jan 25, 2017

but I don't have control how the items are filtered/matched.

I guess this can't be improved on your end then? (I'd expect the exact match to be first)

@alefragnani
Copy link
Owner

Not yet... See #66 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants