Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update property project.build.outputTimestamp at release time #286

Closed
Jurrie opened this issue Mar 14, 2021 · 3 comments
Closed

Comments

@Jurrie
Copy link

Jurrie commented Mar 14, 2021

I am trying to get my build to be reproducible. For this, you have to supply the project.build.outputTimestamp property. This property needs to be updated at release time.

The maven-release-plugin already does this. This is implemented in cfcc8ca59e483. Maybe gitflow-maven-plugin can implement the same?

@aleksandr-m
Copy link
Owner

@Jurrie Thanks for pointing this out!
Do you think project.build.outputTimestamp should be updated on release-start also, or only when finishing a release?

@Jurrie
Copy link
Author

Jurrie commented Mar 15, 2021

Hi @aleksandr-m, I don't know :) I'm currently trying to get our build to be reproducible, updating plugins etc. I'm not yet at the point where I want to update this property.

I think gitflow-maven-plugin should follow maven-release-plugin here as much as possible. The Maven guide states that the maven-release-plugin updates this property in the same commit where it updates the version. I don't actually know if the property will be updated again when the version is set to -SNAPSHOT.

@aleksandr-m
Copy link
Owner

1.16.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants